[SVN Commit] area51/PYQT/devel/py-qt4

[Alonso Schaich]

SVN commit 10356 by aschai:

Fix typo.



M +1 -1 Makefile

[Alonso Schaich]

SVN commit 10357 by aschai:

Fix assignment.

bsd.pyqt.mk is pulled in by the pyqt ports, therefore it _should_ extend USES
instead of resetting them.

Noticed/Reported by Antoine Brodin <***@freebsd.org>



M +1 -1 bsd.pyqt.mk

[Alonso Schaich]

SVN commit 10358 by aschai:

Remove USES.

devel/py-qt4 redundandly adds python USES as it's also added in the included
bsd.pyqt.mk, so it should be safe to remove it from the devel/py-qt4 metaport.



M +0 -2 Makefile

[Max Brazhnikov]

Post by Alonso Schaich
Remove USES.
devel/py-qt4 redundandly adds python USES as it's also added in the included
bsd.pyqt.mk, so it should be safe to remove it from the devel/py-qt4 metaport.

No, it's not. USES in bsd.pyqt.mk is hidden behind PYQT4_DIST, which
is not set in devel/py-qt4.

[Raphael Kubo da Costa]

Post by Max Brazhnikov

Post by Alonso Schaich
Remove USES.
devel/py-qt4 redundandly adds python USES as it's also added in the included
bsd.pyqt.mk, so it should be safe to remove it from the devel/py-qt4 metaport.

No, it's not. USES in bsd.pyqt.mk is hidden behind PYQT4_DIST, which
is not set in devel/py-qt4.

This still needs to be fixed, right?

[Schaich Alonso]

On Wed, 22 Oct 2014 21:44:43 +0300

Post by Raphael Kubo da Costa

Post by Max Brazhnikov

Post by Alonso Schaich
Remove USES.
devel/py-qt4 redundandly adds python USES as it's also added in the included
bsd.pyqt.mk, so it should be safe to remove it from the devel/py-qt4 metaport.

No, it's not. USES in bsd.pyqt.mk is hidden behind PYQT4_DIST, which
is not set in devel/py-qt4.

This still needs to be fixed, right?

Yes, and no ;)

Yes, as in I did not reintroduce it, and no as in it's not "broken", as
the metaport has itself no dependency on python but on packages that
depend on python instead.

[Alonso Schaich]

SVN commit 10439 by aschai:

Revert r10358.



M +2 -0 Makefile

[Raphael Kubo da Costa]

Post by Alonso Schaich
Revert r10358.

FYI, explaining "why" would have been very good here, otherwise 2 years
from now one will have no idea of what caused this to be reverted.